Repository navigation
Re-observe stale hugepage-backed trackers during the background treatment pass. - #1776
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_1009361372
branch
3 times, most recently
from
October 30, 2026 04:49
2424b18 to
828ed47
Compare
…ment pass. Previously, `HugePageUnbackedTrackerTreatment` skipped every tracker whose cached residency state reported that it was hugepage-backed, so a first observation or a successful collapse stood until a page release cleared the bit. A hugepage that the kernel later split through compaction or swap was neither recorded as split nor reconsidered for collapse. Each pass now also selects up to 512 trackers whose hugepage-backed records are older than the five-minute record interval, ordered oldest record first so passes round-robin across large heaps instead of starving the tail. Candidate selection buffers up to twice that limit and compacts the buffer with `std::nth_element` when full, raising a timestamp cutoff so selection remains amortized constant time per tracker while holding the pageheap lock. After dropping the lock, the pass queries pageflags for the selected trackers. Trackers that remain hugepage-backed get a fresh record timestamp, while up to 128 trackers found split per pass have their full residency bitmaps recorded and are treated for collapse and subrelease alongside regular candidates. Re-observation is gated by `Parameters::reobserve_hugepage_backed()` and is disabled by default. Co-authored-by: Chris Kennelly <ckennelly@google.com> PiperOrigin-RevId: 1009361372
copybara-service
Bot
force-pushed
the
test_1009361372
branch
from
November 3, 2026 04:39
828ed47 to
ad6c906
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-observe stale hugepage-backed trackers during the background treatment pass.
Previously,
HugePageUnbackedTrackerTreatmentskipped every tracker whose cached residency state reported that it was hugepage-backed, so a first observation or a successful collapse stood until a page release cleared the bit. A hugepage that the kernel later split through compaction or swap was neither recorded as split nor reconsidered for collapse.Each pass now also selects up to 512 trackers whose hugepage-backed records are older than the five-minute record interval, ordered oldest record first so passes round-robin across large heaps instead of starving the tail. Candidate selection buffers up to twice that limit and compacts the buffer with
std::nth_elementwhen full, raising a timestamp cutoff so selection remains amortized constant time per tracker while holding the pageheap lock.After dropping the lock, the pass queries pageflags for the selected trackers. Trackers that remain hugepage-backed get a fresh record timestamp, while up to 128 trackers found split per pass have their full residency bitmaps recorded and are treated for collapse and subrelease alongside regular candidates.
Re-observation is gated by
Parameters::reobserve_hugepage_backed()and is disabled by default.Co-authored-by: Chris Kennelly ckennelly@google.com