Skip to content

Revert: Adding an ablation study for understanding the performance trade-offs of using a shorter demand cycle. #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −16
Draft

Revert: Adding an ablation study for understanding the performance trade-offs of using a shorter demand cycle. #1813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tcmalloc/experiment_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ enum class Experiment : int {
// clang-format off
// go/keep-sorted start
TCMALLOC_CFL_PRIORITIZATION_ABLATION, // TODO: b/567166830 - Complete experiment.
TCMALLOC_DEMAND_CYCLE_120S, // TODO: b/540987155 - Complete experiment.
TCMALLOC_PGHO_EXPERIMENT, // TODO: b/460486507 - Complete experiment.
TCMALLOC_RELEASE_DRAINED_METADATA_ABLATION, // TODO: b/205153285 - Complete experiment.
TCMALLOC_RELEASE_FREE_STALE, // TODO: b/527473378 - Complete experiment.
Expand Down Expand Up @@ -58,7 +57,6 @@ struct ExperimentConfig {
inline constexpr ExperimentConfig experiments[] = {
// go/keep-sorted start
{Experiment::TCMALLOC_CFL_PRIORITIZATION_ABLATION, "TCMALLOC_CFL_PRIORITIZATION_ABLATION"},
{Experiment::TCMALLOC_DEMAND_CYCLE_120S, "TCMALLOC_DEMAND_CYCLE_120S"},
{Experiment::TCMALLOC_PGHO_EXPERIMENT, "TCMALLOC_PGHO_EXPERIMENT"},
{Experiment::TCMALLOC_RELEASE_DRAINED_METADATA_ABLATION, "TCMALLOC_RELEASE_DRAINED_METADATA_ABLATION"},
{Experiment::TCMALLOC_RELEASE_FREE_STALE, "TCMALLOC_RELEASE_FREE_STALE"},
Expand Down
14 changes: 0 additions & 14 deletions tcmalloc/parameters.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,20 +126,6 @@ static std::atomic<bool>& hpaa_subrelease_ptr() {
}

void Parameters::InitializeFromExperiments() {
#if !defined(TCMALLOC_INTERNAL_SMALL_BUT_SLOW)
if (IsExperimentActive(Experiment::TCMALLOC_DEMAND_CYCLE_120S)) {
skip_subrelease_short_interval_ns_.store(
absl::ToInt64Nanoseconds(absl::Seconds(60)), std::memory_order_relaxed);
skip_subrelease_long_interval_ns_.store(
absl::ToInt64Nanoseconds(absl::Seconds(300)),
std::memory_order_relaxed);
skip_subrelease_cold_short_interval_ns_.store(
absl::ToInt64Nanoseconds(absl::Seconds(60)), std::memory_order_relaxed);
skip_subrelease_cold_long_interval_ns_.store(
absl::ToInt64Nanoseconds(absl::Seconds(300)),
std::memory_order_relaxed);
}
#endif

if (IsExperimentActive(Experiment::TCMALLOC_SONIC_TRACK_BROKEN_HUGEPAGES)) {
track_broken_hugepages_.store(TrackBrokenHugepages::kEnabled,
Expand Down
Loading