Skip to content

fix(cl): ctx.aliasType fix - #1102

Merged
xushiwei merged 2 commits into
goplus:mainfrom
xushiwei:q
Oct 25, 2026
Merged

xushiwei merged 2 commits into
goplus:mainfrom
xushiwei:q

Conversation

@xushiwei

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.26%. Comparing base (b5682e8) to head (1168c01).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   90.25%   90.26%   +0.01%     
==========================================
  Files          26       26              
  Lines        3272     3276       +4     
==========================================
+ Hits         2953     2957       +4     
  Misses        319      319              
Flag Coverage Δ
llgo-tests 90.26% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a well-scoped fix for #1100: when a TypeAlias config entry is a self-reference ("Color": ".Color") whose target is the same package-local name as the C type, aliasType now registers the already-resolved type object and marks it public via addPublicType, instead of falling through to doAliasType and emitting a self-referential type Color = Color. The goTypeOf -> goTypeOfEx split is clean (additive return value, no behavior change for existing callers) and follows the existing *Ex naming convention. The fixture move from _testc/raylib2 to _testpub/raylib is complete (no dangling raylib2 references) and, run via TestPub with savePubFile=true, it now asserts the generated llcppg.pub contains T Color Color, giving real coverage of the fix.

go vet ./cl/ is clean. I could not run the test suite in this sandbox because it requires the llgo CGo/link toolchain (undefined llgo.* / clang symbols at link time), which is unrelated to this change.

Findings below are minor and non-blocking.

Comment thread cl/typedef.go
Comment thread cl/typedef.go
Comment thread cl/ctx.go
@xushiwei
xushiwei merged commit f434f25 into goplus:main Oct 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant