Repository navigation
fix(cl): ctx.aliasType fix - #1102
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
+ Coverage 90.25% 90.26% +0.01%
==========================================
Files 26 26
Lines 3272 3276 +4
==========================================
+ Hits 2953 2957 +4
Misses 319 319
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
This is a well-scoped fix for #1100: when a TypeAlias config entry is a self-reference ("Color": ".Color") whose target is the same package-local name as the C type, aliasType now registers the already-resolved type object and marks it public via addPublicType, instead of falling through to doAliasType and emitting a self-referential type Color = Color. The goTypeOf -> goTypeOfEx split is clean (additive return value, no behavior change for existing callers) and follows the existing *Ex naming convention. The fixture move from _testc/raylib2 to _testpub/raylib is complete (no dangling raylib2 references) and, run via TestPub with savePubFile=true, it now asserts the generated llcppg.pub contains T Color Color, giving real coverage of the fix.
go vet ./cl/ is clean. I could not run the test suite in this sandbox because it requires the llgo CGo/link toolchain (undefined llgo.* / clang symbols at link time), which is unrelated to this change.
Findings below are minor and non-blocking.
GoFiles— mixing hand-written and generated Go code #1100