Repository navigation
docs(RELEASING): correct the Homebrew formula PR merge step - #812
Merged
Merged
Conversation
Approving the PR's held `pull_request` runs lets its own CI report the required `CI Result` check, so the formula PR merges like any other, without an admin merge.
hakula139
added
the
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the Homebrew formula PR step in
RELEASING.md. The step now tells maintainers to approve the PR's held runs in the Actions tab, wait for the PR's checks, and squash-merge normally. Approving those runs lets the PR's own CI report the requiredCI Resultcheck, so the previous instructions to wait for the dispatched run and merge with--adminwere wrong.Evidence from the v0.1.0-alpha.10 release:
CI Resultpassed.mergeStateStatusbecameCLEAN, andgh pr merge 811 --squash --match-head-commit <head>merged to a720001 without--admin.Related to #364. The App-token change and the removal of the dispatched CI run it tracks remain open.
Test plan
nix develop .#lint -c pnpm format: passnix develop .#lint -c pnpm lint: passnix develop .#lint -c pnpm spellcheck: passnix develop .#lint -c cargo deny --locked check: pass