Skip to content

docs(skills): Measurement index semantics on the QICK seam — intonatissimo + intonatoqick - #2003

Open
aarontrowbridge wants to merge 1 commit into
mainfrom
skills-measurement-index
Open

aarontrowbridge wants to merge 1 commit into
mainfrom
skills-measurement-index

Conversation

@aarontrowbridge

Copy link
Copy Markdown
Member

Closes #2002.

Changes

  • intonatissimo (entitled): the Measurement index is a knot index π_j ∈ 1:N on the simulated/objective path; new hardware-path index caveat — through StrumentoExperiment → StrumentoBackend → MockSoc/TwinSoc/StrumentoSoc the integers are DAC-sample indices while the returned Measurements keep the knot label, so ILC would "correct" a timing artefact. Workaround: pass round(Int, t_k*dac_rate)+1, or knots on the DAC grid; check one evaluation against SimulatedExperiment. revision: 1.
  • intonatoqick (public): archived banner (IntonatoQICK.jl archived → renamed Strumento.jl; the seam now lives in Intonato, Intonato 0.5 absorbs the socs); the "converges as dac_rate rises" claim replaced by the index semantics; the verification contract now compares the mock at the knot's time against SimulatedExperiment. revision: 1. No internal-path shapes (the Salvage the amico-plugin un-landed skills: #45 promote, #42 intonatoqick, the restricted 6th vault kind #851 guard).

Evidence (file:line)

  • Intonato main cfc340d: src/types/measurements.jl:1-9, types/measurement_models.jl:9, types/experiments.jl:94-103, hardware/strumento_backend.jl:24, hardware/integration_test.jl:14-37
  • Strumento.jl main 2a01e71: ext/StrumentoPiccoloExt.jl:60-65 (nsamp = floor(Int, T*dac_rate)+1), :227-238 (reads knot_times[k] for k in prog.indices of the DAC-grid reconstruction), ext/StrumentoPythonCallExt.jl:389-420 (truncates at times[1:k] of the DAC grid)
  • Intonato PR 1.2 — RunsManager → multi-run #57 ef1ab83: src/hardware/mock_soc.jl:88-96, src/twins/twin_soc.jl:267-274
  • IntonatoQICK.jl main db4a5f8: src/mock_soc.jl:47-64 (same semantics via SimulatedExperiment on the DAC-grid recon); repo archived

Gates

  • npm run lint:skills (packages/extension, --known) → 38 skills, 0 error(s), 5 warning(s) — ok (same 5 pre-existing warnings as main)
  • vitest run test/skill_salvage_851.test.ts + the skill tests (test/*skill*, test/scores/skill_drift_lint, test/ops/skill_freshness_orchestrator) → 7 files, 201 tests passed

Companion vault PR (internal intonato-dev card): harmoniqs/armonissima#160.

Do not merge without human review.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7db4550c-072c-4004-af40-cf82a8e40f4b
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(skills): Measurement index semantics on the QICK seam — intonatissimo + intonatoqick

1 participant