Repository navigation
fix(notturno): hermetic sandbox gates (CI env, scratch HOME) + failing test files named in RESULT - #2009
Merged
Conversation
…, GITHUB_ACTIONS=true, scratch empty HOME, ambient secrets scrubbed) and a red suite names its failing files (first 5, +N more) in the RESULT line (#2007)
…nv -i + CI=true GITHUB_ACTIONS=true TZ=UTC RUNNER_TEMP GITHUB_BASE_REF, fresh empty scratch HOME per suite, package-local vitest bin; JSON reporter on every suite → RESULT names failing files (quarantine-gate violations for amico-run); build is its own step; warn on node≠20 / root (#2007)
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2007.
env -iwith CI's flags (CI,GITHUB_ACTIONS,TZ=UTC,RUNNER_TEMP,GITHUB_BASE_REF) and a fresh empty HOME for each suite.warn:lines appear when Node isn't 20 or the user is root.Director gate: notturno_gates.test 13/13, typecheck 0, drift 0.
Not yet verified in a real Modal sandbox. The next night's RESULT lines will name any remaining environment-dependent files; the suspects are root (chmod-000 tests), Node 24, and papers.test's hard-coded
/Users/aaronpath.