Skip to content

fix(notturno): hermetic sandbox gates (CI env, scratch HOME) + failing test files named in RESULT - #2009

Merged
aarontrowbridge merged 3 commits into
lane/0.4.0from
opencode/2007-sandbox-gates
Oct 29, 2026
Merged

aarontrowbridge merged 3 commits into
lane/0.4.0from
opencode/2007-sandbox-gates

Conversation

@aarontrowbridge

Copy link
Copy Markdown
Member

Closes #2007.

  • Vitest steps now run under env -i with CI's flags (CI, GITHUB_ACTIONS, TZ=UTC, RUNNER_TEMP, GITHUB_BASE_REF) and a fresh empty HOME for each suite.
  • The script calls each package's own vitest binary.
  • A JSON reporter feeds the RESULT line, which now lists up to 5 failing files per suite.
  • warn: lines appear when Node isn't 20 or the user is root.

Director gate: notturno_gates.test 13/13, typecheck 0, drift 0.

Not yet verified in a real Modal sandbox. The next night's RESULT lines will name any remaining environment-dependent files; the suspects are root (chmod-000 tests), Node 24, and papers.test's hard-coded /Users/aaron path.

…, GITHUB_ACTIONS=true, scratch empty HOME, ambient secrets scrubbed) and a red suite names its failing files (first 5, +N more) in the RESULT line (#2007)
…nv -i + CI=true GITHUB_ACTIONS=true TZ=UTC RUNNER_TEMP GITHUB_BASE_REF, fresh empty scratch HOME per suite, package-local vitest bin; JSON reporter on every suite → RESULT names failing files (quarantine-gate violations for amico-run); build is its own step; warn on node≠20 / root (#2007)
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a9834f37-1286-4f74-b902-eb03aa336875

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aarontrowbridge
aarontrowbridge merged commit a3e1b55 into lane/0.4.0 Oct 29, 2026
12 checks passed
aarontrowbridge added a commit that referenced this pull request Oct 29, 2026
0.4.0 backlog integration: 26 PRs + What's-new (#2001) + hermetic night gates (#2009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant