Repository navigation
fix(releases): bake the version into the runner bundle + ship releases/ beside it (#2017) - #2018
Merged
Merged
Conversation
… beside it (#2017) The hub's standalone service runner has no package.json near it, so resolveOwnVersion() fell back to 0.0.0 and /amicode/releases filtered every card. Resolve AMICODE_VERSION, then an esbuild-defined __AMICODE_VERSION__ (extension + runner bundles), then the package.json walk. Copy docs/releases/*.md to bin/dist/releases too, found via <here>/releases. resolveOwnVersion/resolveReleasesDir take an injectable dir for tests.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2017. Version resolution order is now
AMICODE_VERSION, then the build-time__AMICODE_VERSION__define, then package.json. docs/releases/*.md is also copied tobin/dist/releases. Director: tc 0, releases vitest 20/20. Hub check after merge.