feat: [FME-19823]: wire --comment/--title into CLI delete for feature_flag, environment, and segment:definition - #265
Merged
Conversation
…_flag, environment, and segment:definition FME-19742 (PR #12932) added comment/title audit fields to the v4 delete endpoints for feature flags, environments, and segment definitions, all as a JSON body (no @QueryParam). delete feature_flag and delete fme_environment had no --comment/--title flags at all; delete segment:definition had stale query-param wiring from before FME-19742 that now 400s against the merged backend ("Missing required title"). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
puthrayaharness
approved these changes
Oct 2, 2026
apetruccelli
added a commit
to apetruccelli/cli
that referenced
this pull request
Oct 2, 2026
Resolve spec/test conflicts: keep main's body-based segment:definition delete (comment/title, harness#265) and drop the superseded query-param tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FME-19742 (PR #12932) added
comment/titleaudit fields to the v4 delete endpoints for feature flags, environments, and segment definitions — all as a JSON body (ArchiveUnarchiveRequest/SegmentDefinitionDeleteRequest, no@QueryParam).delete feature_flag: had no--comment/--titleflags at all. Added them, sent as a JSON body, omitted (not sent as null/empty) when unset.delete fme_environment: same gap, same fix.delete segment:definition: already had--comment/--title, but wired as query params from before FME-19742. The merged backend now rejects that (400 Missing required title) since it expects a body. Moved tobody_paramsto match.Verified live end-to-end against qa0: created a feature flag, segment, and segment definition, then deleted each with
--comment/--title— confirmed via--debugthat the request body carries both fields and the server returns 200.delete fme_environmentwas confirmed to send the correct body (request accepted past validation) but full delete success wasn't observed in this qa0 project due to an unrelated409 hasDependents(API tokens scoped to the environment) — a pre-existing backend guard, not caused by this change.Commands
harness delete feature_flag <name> [--comment <text>] [--title <text>]harness delete fme_environment <id> [--comment <text>] [--title <text>]harness delete segment:definition <segment-name> --env <env-id> [--comment <text>] [--title <text>]Acceptance Criteria
--comment/--titleadded todelete feature_flag, sent as a JSON body--comment/--titleadded todelete fme_environment, sent as a JSON bodydelete segment:definitionmoved from query params to a JSON body for--comment/--titlego test ./pkg/...passesgo build ./...,gofmt, andgo vetclean🤖 Generated with Claude Code