Skip to content

Check warden message for timeout instead of flash[:timedout] - #5875

Open
SergiuLupaiescu wants to merge 1 commit into
heartcombo:mainfrom
SergiuLupaiescu:fix/timeoutable-flash-key
Open

SergiuLupaiescu wants to merge 1 commit into
heartcombo:mainfrom
SergiuLupaiescu:fix/timeoutable-flash-key

Conversation

@SergiuLupaiescu

@SergiuLupaiescu SergiuLupaiescu commented Oct 20, 2026 •

Copy link
Copy Markdown

Relying on flash[:timedout] to detect a timeout redirect is fragile, it depends on the flash being set and carried across the redirect. The warden failure message is available via warden_message and is the more direct source.

Fixes #5722

@SergiuLupaiescu
SergiuLupaiescu force-pushed the fix/timeoutable-flash-key branch from 3a61a7f to f2b4975 Compare October 20, 2026 06:26
@SergiuLupaiescu
SergiuLupaiescu marked this pull request as ready for review October 20, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Weird flash message with Timeoutable

1 participant