Repository navigation
fix: restrict private cloud destination connections - #1149
Draft
TroyCoombs wants to merge 1 commit into
Draft
TroyCoombs wants to merge 1 commit into
TroyCoombs wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authenticated destination managers could point cloud destination clients at private or local services reachable from an Outpost worker. Add a shared connection-time address policy for AWS EventBridge, Kinesis, SQS, S3, and GCP Pub/Sub. It checks the resolved IPv4/IPv6 address immediately before each TCP connection, including connections after AWS redirects, and applies when publishers are created for existing records.
queue_urlwhen it determines the endpoint, and reject unsupported Pub/Sub resolver schemes.DESTINATIONS_CLOUD_ALLOWED_CIDRS.The report is valid at the source/provider level. Recommended priority is P2 / Medium, provisional pending confirmation of the deployed version and effective production egress controls. The submitted evidence does not establish secret-key theft, platform credential compromise, cross-tenant data exposure, or privileged internal actions.
Reply to the reporter (draft; not sent)
Compatibility and rollout
DESTINATIONS_CLOUD_ALLOWED_CIDRSranges before upgrading deployments that use private endpoints. This applies to existing destinations as well.HTTP_PROXY,HTTPS_PROXY, orALL_PROXY. The existingDESTINATIONS_PROXY_URLcoverage is unchanged.host:port.Validation
Passed in disposable Linux containers using Go 1.27.2:
git diff --cached --checkgo test -p 2 ./internal/destregistry/... ./internal/config -short -count=1go test -p 2 ./... -short -count=1go test -p 2 ./internal/destregistry/... -short -count=1 -v -run "^(TestCloud|TestSQSQueueURL|TestPubSubEndpointConnectionPolicy)"The new cases exercise all five actual providers against local receivers: forbidden private destinations receive no requests, and explicitly allowed emulators successfully receive deliveries. Additional cases cover mapped IPv6, link-local/metadata addresses, hostname resolution, 307/308 redirects, environment-proxy configuration, SQS queue URLs, existing records, tenant attempts to override the deployment policy, and environment/YAML configuration.
An initial run hit an existing registry TTL timing test under higher parallel load; it passed unchanged with
-p 2. Live cloud accounts, production endpoints, and the full external-broker integration suite were not exercised.