Repository navigation
Conversation
daniel-slaugh
requested changes
Oct 19, 2026
daniel-slaugh
left a comment
daniel-slaugh
left a comment
Contributor
There was a problem hiding this comment.
Requesting two changes. After these are resolved, looks good to me:
- In our message thread with Alex, we agreed to make skip gaps the default. This PR still has stop on gap as the default.
- The field is still called stop_on_no_data but the UI says "Stop on input gaps". The misnomer will be confusing for client users so I recommend migrating the field to stop_on_gaps or something.
Contributor
Author
|
@daniel-slaugh I've renamed the field to stopOnGaps and updated the default behavior. I'll note that this is a breaking change in the release notes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #571