Skip to content

evaluations: tolerate malformed evaluator hydration - #38

Merged
Kzoeps merged 2 commits into
mainfrom
evaluations/tolerant-evaluator-hydration
Oct 7, 2026
Merged

Kzoeps merged 2 commits into
mainfrom
evaluations/tolerant-evaluator-hydration

Conversation

@Kzoeps

@Kzoeps Kzoeps commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve original evaluation records and omit malformed evaluator entries from the separate dense hydrated projection instead of failing GET or hiding the evaluation from lists.
  • Missing/non-array evaluator containers project as empty arrays; valid object entries preserve relative order and duplicates.
  • Retain the existing source-position-100 hydration boundary and 1,000-entry safety cap (over-limit GET fails, list skips).
  • Update shared Lua and generated GET/list handlers, public projection contracts, explorer and consumer skill snapshots, HTTP/unit regressions, and patch Changeset.

Validation

  • Independent read-only review: no confirmed correctness findings.
  • node --test api/tests/unit/context/evaluation.test.js: 13 passed, including raw preservation, mixed/all-invalid data, empty projections, source-position boundary, pagination and over-limit scanning.
  • node api/tooling/build-lua.js --check and git diff --check: passed.
  • pnpm docs:sync completed with existing read-only pinned Lexicon dependency; 55 endpoint snapshots, no unresolved references.

Limitations

  • Added HTTP regression fixtures/tests were not executed; Docker runtime was unavailable/not authorized for this task.
  • Full lint, typecheck, and Changesets CLI validation were not run because this worktree lacks installed dependencies. No installs performed.
  • HappyView typed XRPC error mapping is a separate task; ordinary Lua runtime error behavior is unchanged.

@changeset-bot

changeset-bot Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5f875a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hypercerts-org/hypercerts-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-endpoints Ready Ready Preview Oct 7, 2026 10:31am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2c453e51-8fce-46a0-bb21-cb9899d528dd
📥 Commits

Reviewing files that changed from the base of the PR and between 9a92a74 and 5f875a2.

📒 Files selected for processing (15)
  • .agents/skills/hypercerts-api/references/endpoint-map.md
  • .agents/skills/hypercerts-api/references/openapi.json
  • .agents/skills/hypercerts-api/references/reliability.md
  • .changeset/tolerate-malformed-evaluation-evaluators.md
  • api/lexicons/org.hypercerts.context.getEvaluation.json
  • api/lexicons/org.hypercerts.context.listEvaluations.json
  • api/lua/endpoints/getEvaluation.lua
  • api/lua/endpoints/listEvaluations.lua
  • api/lua/shared/evaluation.lua
  • api/tests/http/context-evaluations.http.test.js
  • api/tests/http/fixtures/context-evaluations.fixture.js
  • api/tests/unit/context/evaluation.test.js
  • docs/openapi.json
  • docs/sources/lexicons/org.hypercerts.context.getEvaluation.json
  • docs/sources/lexicons/org.hypercerts.context.listEvaluations.json
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 7, 2026

Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@Kzoeps
Kzoeps merged commit a830b9b into main Oct 7, 2026
7 of 8 checks passed
@Kzoeps
Kzoeps deleted the evaluations/tolerant-evaluator-hydration branch October 7, 2026 10:50
@github-actions github-actions Bot mentioned this pull request Oct 7, 2026

This branch was successfully deployed

1 active deployment
Preview — 5f875a28 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant