Skip to content

api: remove unused manifest metadata - #39

Merged
Kzoeps merged 1 commit into
mainfrom
api/remove-unused-manifest-metadata
Oct 9, 2026
Merged

Kzoeps merged 1 commit into
mainfrom
api/remove-unused-manifest-metadata

Conversation

@Kzoeps

@Kzoeps Kzoeps commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Remove unused status, runtime-compatibility, and authentication metadata from the aggregate API manifest.
  • Remove assertions against those fields while retaining handler registration and bundle checks.

Validation

  • pnpm check: passed (346 API unit tests and 17 docs tests).
  • git diff --check: passed.

No runtime or installed asset behavior changes.

Summary by CodeRabbit

  • Chores
    • Updated API package metadata: runtime compatibility, target revision, handler implementation status, and public-authentication details are no longer listed.
    • Validation lexicons, available modules, and Lua build configuration remain unchanged.
    • No changes to end-user functionality are described in this update.

@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 41accc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
api-endpoints Skipped Skipped Oct 9, 2026 12:17pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 26d30a11-369f-4ff7-bb1e-ab9c277f62b2

📥 Commits

Reviewing files that changed from the base of the PR and between 4daa7f2 and 41accc2.


📒 Files selected for processing (2)
  • api/manifest.json
  • api/tests/unit/tooling/lua.test.js

💤 Files with no reviewable changes (1)
  • api/manifest.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The manifest removes runtime compatibility, target revision, handler implementation status, and public-authentication metadata. Two unit tests stop checking handler implementation status. The Lua test retains checks that handlers are declared and loaded.

Changes

Runtime status metadata

Layer / File(s) Summary
Remove status declarations and assertions
api/manifest.json, api/tests/unit/context/attachment.test.js, api/tests/unit/tooling/lua.test.js
The manifest removes runtime, handler-status, and authentication metadata. The attachment and Lua tests no longer check handler implementation status. The Lua test retains checks that handlers are declared and loaded.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Refactor


Merge Risk: ⚪ Minimal · up to 41acc

The change removes unused manifest metadata while retaining the fields used to declare and load handlers. No merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title is concise and accurately describes the main change: removing unused metadata from the API manifest.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Kzoeps
Kzoeps force-pushed the api/remove-unused-manifest-metadata branch from 4daa7f2 to 57c7e6c Compare October 9, 2026 12:16
@Kzoeps
Kzoeps force-pushed the api/remove-unused-manifest-metadata branch from 57c7e6c to 41accc2 Compare October 9, 2026 12:17
@Kzoeps Kzoeps changed the title api: remove unused manifest status metadata api: remove unused manifest metadata Oct 9, 2026
@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

@Kzoeps
Kzoeps merged commit 52658c3 into main Oct 9, 2026
8 checks passed
@Kzoeps
Kzoeps deleted the api/remove-unused-manifest-metadata branch October 9, 2026 12:25

This branch was previously deployed

1 inactive deployment
Preview — 41accc28 Deployed Oct 9, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant