Repository navigation
Add a one-click deploy button for Railyard - #3463
almokhtarbr wants to merge 1 commit into
Conversation
|
@almokhtarbr is attempting to deploy a commit to the HyperDX Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Hi @almokhtarbr, thanks for the pull request! Before we review code from a first-time contributor, a maintainer vouches for them, and you're not on our list yet. There's nothing else to file and this PR stays open — a maintainer will look at it, usually within a day or two, and vouch for you right here if it's a genuine attempt at the problem. To make that quick, check the PR description has:
More detail in our contributing guide. |
| </p> | ||
|
|
||
| <p align="center"> | ||
| <a href="https://app.railyard.run/deploy?repo=https://github.com/hyperdxio/hyperdx"><img src="https://app.railyard.run/deploy/badge" alt="Deploy to Railyard"></a> |
There was a problem hiding this comment.
🟠 major — Deploy link only passes the repo URL, but the repo has no root Dockerfile
The PR says Railyard deploys by reading the repo's Dockerfile, but the repo root has none. The Dockerfiles are docker/hyperdx/Dockerfile (multi-stage, with targets prod, all-in-one-noauth and all-in-one-auth), packages/api/Dockerfile and packages/app/Dockerfile, plus a multi-service docker-compose.yml. With nothing but ?repo=... in the URL, the button either fails or builds an image the maintainers didn't choose (for example, the last stage all-in-one-auth, which builds ClickHouse, the OTel collector and Node from source). Before merging, test the flow against this repo and add the Dockerfile path and build target to the link, or drop the button and keep pointing users to the documented docker run ... hyperdx-all-in-one image and the deployment docs.
Nothing blocks merge automatically, but a maintainer will expect this fixed if it is a real defect in code this PR changes. If it is about surrounding code, reply and say so instead of patching. Do not widen the PR. How to respond
| <a href="https://trendshift.io/repositories/2030?utm_source=repository-badge&utm_medium=badge&utm_campaign=badge-repository-2030" target="_blank" rel="noopener noreferrer"><img src="https://trendshift.io/api/badge/repositories/2030" alt="hyperdxio%2Fhyperdx | Trendshift" width="250" height="55"/></a> | ||
| </p> | ||
|
|
||
| <p align="center"> |
There was a problem hiding this comment.
🔵 minor — The badge image is hotlinked from a third-party server that can change it at any time
<img src="https://app.railyard.run/deploy/badge"> is served live by an unaffiliated vendor. They can change what it shows whenever they like, and every view of the README sends a request to their server. It also sits above the project description, so it reads as an official endorsement, while the 'production deployment' text a few lines down sends users to the ClickStack docs instead. If maintainers want the link, commit the badge as a static asset (or use plain text) and move it into the deployment section next to the existing options.
Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond
PR Review
2 finding(s): 🔴 0 critical · 🟠 1 major · 🔵 1 minor 2 posted as inline comment(s) on the changed lines. Severity is the reviewer's own estimate and is used for ordering, not filtering. No finding blocks merge automatically; a maintainer decides. |
[Low impact] This README-only change appears safe to merge. SummaryAdds a centered “Deploy to Railyard” badge to
Reviews (1) · Last reviewed commit: "Add a one-click deploy button for Railya..." · Reviewed by Greptile |
Deep Review✅ No critical issues found. This PR is a single-line documentation change: it adds a third-party "Deploy to Railyard" badge to the top of 🟡 P2 -- recommended
🔵 P3 nitpicks (2)
Reviewers (4): correctness, security, maintainability, project-standards. Testing gaps: No way to validate that the deploy link produces a functioning HyperDX instance without an external end-to-end test against the third-party service; accuracy of the one-click claim is unverifiable from the diff alone. No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
Hi, I'm the one building Railyard: a free, BYO-server PaaS that deploys to a server in your own DigitalOcean, Hetzner, Vultr or AWS account, reading the Dockerfile in this repo directly, with no markup on compute.
What this PR does
What clicking it does: opens Railyard's deploy flow pre-filled with this repo's URL. Nothing gets deployed until the person confirms a server and reviews the settings themselves.
No pressure either way, feel free to close if it's not a fit.