Repository navigation
Derived route names that collide get _2, _3 suffixes (#28) - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #28.
Routes named from
operationIdor method + path used to collide silently once sanitised (/a-b,/a_b,/a/ball gaveget_a_b; last one won, soapi_pkg_filesdropped routes).HttpClientnow suffixes derived names_2,_3, ... in spec order and warns; explicitx-method_nameis never changed and is reserved against derived names, and natural names of later routes are reserved against suffixes. The root path/isget_rootinHttpClient(openapi_to_pykeepsget). Generated packages now require http2py>=0.1.40, the release shipping these names.Review (fresh Opus adversarial pass): SHIP-WITH-FIXES. Confirmed and fixed: the generated-package floor was too low; the root rename dropped a route in
openapi_to_py; a suffix could take a later route's natural name. Documented, not changed: names depend on spec order, so pin withx-method_name; a subclass skipping__init__knows no explicit names.Gate:
priv test-dependents http2py --transitive: http2py, extrude, py2http pass.🤖 Generated with Claude Code