Repository navigation
feat: support framework='flask' - #41
Merged
Merged
Conversation
_get_framework accepts bottle and flask; the default error handler and output mapper are chosen per framework instead of by a process-wide env var; mk_flask_app and mk_bottle_app pin their own framework; run_app can run a Flask app. Closes #39 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…asked, wraps middleware Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39.
_get_frameworkaccepts bottle and flask; default error handler and output mapper are chosen per framework (no process-wide env var decides, so a flask app built later cannot change a bottle app's answers);mk_flask_app/mk_bottle_apppin their own framework;run_appcan run Flask (run_flask); end-to-end tests for statuses, WWW-Authenticate, JSON.Adversarial review (fresh Opus): no Bottle regressions. Confirmed and fixed: Flask silently dropped auth plugins (now refuses plugins/enable_cors/publish_swagger/openapi_insecure), /openapi always published (now only with publish_openapi), middleware list unusable (now WSGI wrappers), run_flask dropped TLS with only a certfile (now an error). Deferred to a follow-up issue: non-JSON input mappers, @send_json_resp mappers, empty bodies under Flask.
Dependents gate (
priv test-dependents py2http --transitive): extrude + 1 other suite pass, /dev/null intact.🤖 Generated with Claude Code