Monthly Flarelists by nicHoch · Pull Request #458 · i4Ds/STIXCore

nicHoch · 2026-03-23T09:31:12Z

No description provided.

samaloney · 2026-03-23T09:54:24Z

+        """Hook called after reading data from FITS. Mixins override and chain via super()."""
+        s = super()
+        if hasattr(s, "on_deserialize"):
+            s.on_deserialize(data)


Hum this is a bit of code smell - it's breaking the inheritance pattern - I'd suggestion implement on the base case and either pass or raise not implemented error

i implemented a hopefully more pythonic flow

Fits de/serialize hook for converting into fits serializeable icrs frame

codecov-commenter · 2026-03-26T08:51:28Z

Codecov Report

❌ Patch coverage is 63.73851% with 355 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.27%. Comparing base (3ae9671) to head (10d188d).
⚠️ Report is 20 commits behind head on master.

Files with missing lines	Patch %	Lines
stixcore/products/level3/flarelist.py	37.75%	150 Missing ⚠️
stixcore/products/level3/processing.py	21.09%	101 Missing ⚠️
stixcore/io/FlareListManager.py	84.72%	75 Missing ⚠️
stixcore/processing/pipeline_daily.py	22.22%	14 Missing ⚠️
stixcore/ephemeris/manager.py	20.00%	4 Missing ⚠️
stixcore/io/product_processors/fits/processors.py	55.55%	4 Missing ⚠️
stixcore/products/level3/flarelistproduct.py	57.14%	3 Missing ⚠️
stixcore/processing/FLtoFL.py	0.00%	2 Missing ⚠️
stixcore/io/RidLutManager.py	98.36%	1 Missing ⚠️
stixcore/products/product.py	93.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   72.23%   68.27%   -3.97%     
==========================================
  Files          78       80       +2     
  Lines        8085     9685    +1600     
==========================================
+ Hits         5840     6612     +772     
- Misses       2245     3073     +828

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

samaloney

I still need to check the code out and run it as hard to fully understand from just reading but looks good, left a few minor comments.

samaloney · 2026-03-26T09:08:37Z

    return table_hdu


+def CreateUtcColumn(table, data, colname, description="UTC Time"):


snake case

Suggested change

def CreateUtcColumn(table, data, colname, description="UTC Time"):

def create_utc_column(table, data, colname, description="UTC Time"):

or maybe create_UTC_column not sure what the PEP says for this?

samaloney · 2026-03-26T09:18:23Z

+        CreateUtcColumn(
+            data,
+            [Time(d, format="isot", scale="utc") for d in mt["start_UTC"]],
+            "start_UTC",
+            description="start time of flare",
+        )


data.add_column(Column([Time(d, format="isot", scale="utc") for d in mt["start_UTC"]], name="start_UTC",description="start time of flare")

not sure if the function is need id honest really do much?

samaloney · 2026-03-26T09:21:05Z

        return kwargs["level"] == "L3" and service_type == 0 and service_subtype == 0 and ssid == 8
+
+
+def longest_constant_sequence(state_array):


test for this would be good

samaloney · 2026-03-26T09:21:11Z

+    return max_length, max_start_idx, max_state
+
+
+def calculate_overlap(range1, range2):


test for this would be good

samaloney · 2026-06-08T09:29:57Z

+        solo_sun_hg, sun_solo_lt = spiceypy.spkezr("SOLO", et, "SUN_EARTH_CEQU", "None", "Sun")
+        sun_earth_hee, sun_earth_lt = spiceypy.spkezr("Earth", et, "SOLO_HEE", "None", "Sun")
+
+        return (sun_earth_lt - sun_solo_lt) * u.s


This is in the fits headers not - also is this from sun center or surface?

samaloney · 2026-06-08T09:32:18Z

+        CreateUtcColumn(
+            data,
+            [Time(d, format="isot", scale="utc") for d in mt["start_UTC"]],
+            "start_UTC",
+            description="start time of flare",
+        )


Time(mt["start_UTC"]) does this work?

samaloney · 2026-06-08T09:35:41Z

+            # TODO redo
+            # if f_data_end > (Spice.instance.get_mk_date(meta_kernel_type="flown") - timedelta(hours=24)):
+            #    return TestForProcessingResult.NotSuitable


samaloney · 2026-06-08T10:48:18Z

+                            np.nan * u.km,
+                            np.nan * u.km,
+                            np.nan * u.km,
+                            peak_time,
+                            np.nan * u.km,
+                            np.nan * u.km,
+                            np.nan * u.km,


Why is this a combination of km and time and are these in a a coordinate frame?
Also why is it 3 distances a time and 3 distances?

samaloney · 2026-06-08T10:51:14Z

+            u.Quantity(solo_y),
+            u.Quantity(solo_z),
+            frame=HeliographicStonyhurst(obstime=solo_times),
+            representation_type="cartesian",


did you serialise them as specifically cartesian

Also what about the observer coordinate?

samaloney · 2026-06-08T10:55:07Z

+        super().on_deserialize(data, **kwargs)
+
+    @classmethod
+    def is_visible(cls, coord):


Need to careful about definitions here some of the problems should live on the examine in STIXpy as it depends - some sources can come from the corona

rework documentation structure

samaloney

So the use case for some of the columns isn't clear to me, not to say there isn't a very good use case just I don't know about it.

On the imaging I think the integrated counts used to make the image could be useful to add.

The min and max exposure are of the selected CPD file used for imaging think just need to state there could be ohter files with different values.

Could we link all CPD file the overlap with the flare in a "related" files column?

samaloney · 2026-10-21T14:03:52Z

+
+**review comment:** _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_
+
+#### GOES_class


For consistency Id say either 'GOES' or 'goes' everywhere

samaloney · 2026-10-21T14:05:45Z

+
+**review comment:** _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_
+
+#### goes_min_class_est


I guess we need some documentation with the flare list so can describe where this stuff comes from e.g. the data centre not Muriel's work

samaloney · 2026-10-21T14:06:45Z

+
+**review comment:** _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_
+
+#### goes_max_class_est


So the classes are derived from the flux do we need both?

samaloney · 2026-10-21T14:10:53Z

+
+- **comment:** livetime- and area-corrected flux at the peak lightcurve bin (ct/s/keV/cm2, 5 energy channels)
+- **unit:** ct / (keV s cm2)
+- **example:** `[1.7785, 0.1944, 0.0736, 0.2886, 0.1244] ct / (keV s cm2)`


so this takes care of the det/pixel config so can directly compare counts event to event if the enable dets/pixels had changed?

samaloney · 2026-10-21T14:12:19Z

+
+**review comment:** _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_
+
+#### lc_bkg_peak


which pixel in the bkg det are in this?

samaloney · 2026-10-21T14:25:03Z

+
+- **comment:** minimum CPD per-bin exposure ds (timedel) over the flare start..end window
+- **unit:** ds
+- **example:** `599 ds`


should also be in seconds

samaloney · 2026-10-21T14:25:56Z

+
+**review comment:** the actual time period (center time) on which the location is calculated is defined first in stixcore. The visibility code might (stixpy) might modify the time period to be used for the location calculation
+
+#### location_duration


I'm not sure maybe it would be better to store the imaging timbering e.g start and end time used to make the image.

samaloney · 2026-10-21T14:26:20Z

+
+- **comment:** maximum CPD per-bin exposure ds (timedel) over the flare start..end window
+- **unit:** ds
+- **example:** `792 ds`


same conversation to seconds

samaloney · 2026-10-21T14:27:01Z

+
+**review comment:** _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_
+
+#### time_shift


maybe keep same naming as meta data standard?

samaloney · 2026-10-21T14:28:51Z

+
+**review comment:** _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_
+
+### 6. 1-AU normalization — [`add_distance_normalized_flux`](../stixcore/products/level3/flarelist.py#L94-L110)


Nice to have but since this should be easily calculated from two other columns is it worth it/useful I'm not sure need more user/external feedback

samaloney reviewed Mar 23, 2026

View reviewed changes

nicHoch added 3 commits March 23, 2026 15:09

mixings in columns

12a643d

skyCoords components as single columns

0b5f6c4

SkyCoord for flarePosition

1e3f10c

Fits de/serialize hook for converting into fits serializeable icrs frame

nicHoch force-pushed the flarelist branch from 699a991 to 1e3f10c Compare March 23, 2026 14:11

change on_deserialize flow

a888dcb

enable soop update

4bbc2e8

samaloney reviewed Mar 26, 2026

View reviewed changes

nicHoch added 2 commits March 27, 2026 14:36

experimental fix for reading aspect burst data

776b721

added time_shift and disc_size

46ad35c

samaloney reviewed Jun 8, 2026

View reviewed changes

nicHoch added 3 commits June 22, 2026 13:17

added time_shift and disc_size

83f53ee

add find quiet background files

5e59133

prepare for review

10d188d

rework documentation structure

samaloney reviewed Oct 21, 2026

View reviewed changes

		return table_hdu


		def CreateUtcColumn(table, data, colname, description="UTC Time"):

	def CreateUtcColumn(table, data, colname, description="UTC Time"):
	def create_utc_column(table, data, colname, description="UTC Time"):

		return kwargs["level"] == "L3" and service_type == 0 and service_subtype == 0 and ssid == 8


		def longest_constant_sequence(state_array):

		return max_length, max_start_idx, max_state


		def calculate_overlap(range1, range2):


		review comment: _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_

		#### GOES_class


		review comment: _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_

		#### goes_min_class_est


		review comment: _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_

		#### goes_max_class_est


		review comment: _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_

		#### lc_bkg_peak


		review comment: the actual time period (center time) on which the location is calculated is defined first in stixcore. The visibility code might (stixpy) might modify the time period to be used for the location calculation

		#### location_duration


		review comment: _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_

		#### time_shift


		review comment: _(to be filled in via `notebooks/flarelist_sdcloc_review_comments.yaml`)_

		### 6. 1-AU normalization — [`add_distance_normalized_flux`](../stixcore/products/level3/flarelist.py#L94-L110)

Conversation

nicHoch commented Mar 23, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

samaloney left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

samaloney left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-commenter commented Mar 26, 2026 •

edited

Loading