Repository navigation
Conversation
- Add modern Homebrew bash to the Brewfile, ahead of bat in CLI tools - Document the optional g3rm0n monitoring dashboard in README and INSTALLATION - Add tests/brewfile_test.py regression for the Bash entry and jq uniqueness - Record the changes under Unreleased in CHANGELOG
iamgerwin
commented
Oct 19, 2026
iamgerwin
left a comment
Owner
Author
There was a problem hiding this comment.
Code Review — Claude Code (claude-haiku-5-5)
Verdict: ✅ Approve (blocking finding resolved during review)
What checks out
- Brewfile:
brew "bash"sits in "Command Line Tools & Development" directly beforebat; sorting correct (bash<bat).jqappears exactly once — no duplicate. - Test runner:
scripts/check.shrunsunittest discover -s tests -p '*_test.py', sotests/brewfile_test.pyruns locally and in CI. Prefix match includes the closing quote (brew "bash"), sobashful-style names won't false-match. - Changelog: entries under
[Unreleased]in correct Keep a Changelog format;VERSIONcorrectly unchanged. - Docs formatting: README and INSTALLATION.md additions match the neighbouring bullet and fence style.
- Setup scripts:
setup.sh,scripts/update-all.sh,adaptive-setup.shonly readbrew/casklines from the Brewfile — one added formula line doesn't change their behaviour.
Findings and resolution
- Claim "installs to
~/.local, no root" — ✅ Verified against upstreaminstall.sh: installs only to~/.local/share/g3rm0n,~/.local/bin, and XDG user dirs (fish config, bash-completion, zsh site-functions). Nosudo, no root, no PATH/rc edits beyond managed completion symlinks. Claim is accurate. - Brittle adjacency assertion (
assertEqual(bash_index + 1, bat_index)) — ✅ Fixed in f095127: nowassertLess(bash_index, bat_index)so a future entry between them doesn't break the test. - Test name vs assertion — ✅ Fixed in f095127: renamed to
test_bash_sits_in_command_line_tools_section_sorted. - Minor, non-blocking: the
curl | bashdocs pattern matches the existing convention inubuntu/vps-setup.sh(unpinned remote execution is a known trade-off here). The "bash and jq already come from the Brewfile" phrasing is macOS-scoped, which is the audience of this repo.
Not verified in review environment: scripts/check.sh full run requires zsh, which isn't installed on this Linux box — environmental, pre-existing, unrelated to this diff. The unittest suite (31 tests) passes on main and on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for installing g3rm0n, a live terminal dashboard for system and AI usage.
Changes
brew "bash"(modern Bash; macOS ships Bash 3.2) in Command Line Tools & Development.jqis already present.g3rm0n install