Repository navigation
Conversation
This is particularly important for multi series file in OMERO as they are named: file_name.ext [file_name.ext (seriesx)]
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #155 +/- ##
====================================
Coverage 33% 33%
====================================
Files 25 25
Lines 1806 1819 +13
====================================
+ Hits 591 604 +13
Misses 1215 1215 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
➡️ Please add tests 🧪 for this. |
ehrenfeu
self-requested a review
September 16, 2026 13:44
ehrenfeu
added
unit testing
Contributor
Author
|
I added tests but I think I broke codecov since it's been running for 17hours and still ongoing... |
ehrenfeu
requested changes
Oct 8, 2026
Comment on lines
+208
to
+216
| for index in range(len(text) - 1, -1, -1): | ||
| if text[index] == "]": | ||
| if end is None: | ||
| end = index | ||
| depth += 1 | ||
| elif text[index] == "[": | ||
| depth -= 1 | ||
| if depth == 0: | ||
| return text[index + 1 : end] |
Member
There was a problem hiding this comment.
Sorry, but I'm really struggling to understand what the nested range(), depth and index are doing and how they're playing together, please add comments that explain the code.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is particularly important for multi series file in OMERO as they are named: file_name.ext [file_name.ext (seriesx)]