Repository navigation
fix: observe draft replacements in find predicates - #1352
Open
minjungsung wants to merge 1 commit into
Open
minjungsung wants to merge 1 commit into
minjungsung wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the array-methods plugin enabled,
findandfindLastkeep reading the original array when their predicate triggers the first draft copy by replacing a later element. A predicate that replaces the next element with{ id: 9 }and then searches forid === 9incorrectly returnsundefined.Read the latest array source for each predicate invocation, while retaining the initial iteration length and direction. Add regressions for both methods with the plugin enabled and disabled, and auto-freezing enabled and disabled.
Validation:
Build validation used the TypeScript and Node type versions pinned by the existing yarn.lock, without changing dependency metadata.
AI assistance: implementation, tests, and this description were prepared with Codex.