Repository navigation
[deploy] Make CockroachDB and core-service kubernetes resources configurable - #1759
Merged
Merged
Conversation
MariemBaccari
marked this pull request as ready for review
October 7, 2026 13:04
MariemBaccari
force-pushed
the
config_resources
branch
from
October 23, 2026 09:16
d10ce8b to
1e6227f
Compare
the-glu
reviewed
Oct 23, 2026
MariemBaccari
force-pushed
the
config_resources
branch
from
October 23, 2026 09:33
1e6227f to
f506a36
Compare
MariemBaccari
force-pushed
the
config_resources
branch
from
October 23, 2026 09:41
f506a36 to
ed92494
Compare
the-glu
approved these changes
Oct 23, 2026
Member
|
For extensive testing, I also validated with usual terrafrom/aws-tanka/gke-helm deployments without an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a chain of PRs (#1758, #1759 and #1760) which implements a partial fix to #1731.
It makes the kubernetes resources for crdb and core-service configurable.
This was tested with a local deployment using Minikube. The scenarios tested included the default variables and overriding them.