Repository navigation
Allow touching existing read-only files - #272
Open
Apeksha9389 wants to merge 1 commit into
Open
Apeksha9389 wants to merge 1 commit into
Apeksha9389 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path.touch()opens an existing file for writing before updating its timestamps. On POSIX, a read-only file owned by the caller therefore raisesPermissionError, although the timestamp update itself is permitted.Delegate to
pathlib.Path.touch(), which attempts the timestamp update before creating a missing file, and preserve the chainable return value. The regression test checks timestamp changes, unchanged content, and unchanged permissions. Add a Towncrier fragment.Validation on macOS/Python 3.12:
tox -e py312passes (165 passed, 1 skipped), including mypy and documentation checks. Explicit Ruff lint and formatting checks pass. The new regression fails on unmodified main. Windows and the other Python versions were not run locally.AI disclosure: The patch, tests, and description were prepared with OpenAI Codex assistance; the reported checks were executed locally.