Repository navigation
Restore original files when in-place setup fails - #273
Open
Apeksha9389 wants to merge 1 commit into
Open
Apeksha9389 wants to merge 1 commit into
Apeksha9389 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If opening either stream fails during
Path.in_place()setup, the original file has already been renamed to its backup and is never restored. For example, an invalid encoding leaves the original filename missing; a replacement-file creation failure also leaks the reader.Move setup inside the rollback handler and manage the streams and replacement descriptor with
ExitStack. Cleanup now closes acquired resources before restoring the original file. Four regression cases cover invalid reader encoding/mode, replacement creation failure, and failure to wrap its descriptor. Include a Towncrier fragment.This complements #252, which handles interruption exceptions after setup; it preserves the existing exception class handled by rollback.
Validation on macOS/Python 3.12: all four new cases fail on unmodified main.
tox -e py312passes (168 passed, 1 skipped), including mypy and documentation checks. Explicit Ruff lint and formatting checks pass. Windows and the other Python versions were not run locally.AI disclosure: The patch, tests, and description were prepared with OpenAI Codex assistance; the reported checks were executed locally.