Repository navigation
Recover blocked threads using bounded web comment fragments - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reddit now returns HTML 403s for thread JSON routes while listings and
/by_idmetadata still work. Fall back to Reddit's web comment fragments only for that explicit block, preserving the existing JSON path and rendering behavior otherwise.Adapt the comment parser/tree crawler from redlib-org#599, with the existing Hyper/native-tls transport, HTTP/1.1 ALPN, a separate anonymous cookie jar, same-origin fragment-only redirects, sanitized comment HTML and proxied media. Bound response size, concurrency, expansion count, cache size and elapsed time; retain reply links when expansion fails. Handle missing parents and cyclic ancestry safely.
This adds scraper, ammonia and cookie_store and raises the Rust minimum to 1.88. Web fragments expose less flair/award/embed metadata and require more requests; the fallback can still be blocked upstream. Generic operating notes are in FORK.md.
Validation: formatting and Clippy pass; 64 offline tests pass. Local live checks cover listings, threads, permalinks, additional replies, sorting, comment search, an empty thread and proxied media. An isolated Linux/OpenSSL probe also fetched web fragments successfully with HTTP/1.1 ALPN.