Repository navigation
Conversation
defer TLS closure validation until decrypted plaintext is drained, so framed responses can be consumed before a missing close_notify
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| def check_support(key_type, version) | ||
| sunjsse = jruby? && java.lang.System.getProperty('jruby.openssl.provider.ssl') == 'false' | ||
| java_version = self.class.java_version.last.to_i if jruby? | ||
| skip 'SunJSSE requires Java 11 for TLS 1.3' if sunjsse && version == 'TLSv1_3' && java_version < 11 |
| skip 'SunJSSE requires Java 11 for TLS 1.3' if sunjsse && version == 'TLSv1_3' && java_version < 11 | ||
| if key_type == 'ed25519' | ||
| omit_on_fips | ||
| skip 'SunJSSE requires Java 15 for Ed25519' if sunjsse && java_version < 15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 0.19 we prefer BC-JSSE, but our own key manager only matched a plain key type like
EC. BC asks forECDHE_ECDSAorEC/secp256r1-> EC and Ed25519 servers failed every handshake once a TLS version was set (in FIPS mode we always failed).Instead of teaching
chooseAliasevery spelling, this drops the custom key manager. Credentials instead go into a small in-memoryKeyStore, and the provider's ownPKIXkey manager picks one.Keys are passed through as they are - opaque (FIPS) keys are never re-encoded.