Repository navigation
Refine booking gear, Nitrox checks and manifest ops - #285
Conversation
Consolidate equipment terminology to Lead Weights across the booking wizard, gear profiles, and operations dashboard. Apply standard sizing defaults for full equipment rentals and remove redundant badge labels. Update agency certification gas specifications so recreational depth ratings default to Air while specialized ratings grant Nitrox. Connect Nitrox eligibility to the diver's active portfolio in checkout context, and treat unverified EAN32 bookings as non-blocking pending dockside verification with support for secondary Nitrox credentials. Add default cylinder valve fittings and daily insurance pricing to center booking settings in consolidated database migration 0107. Unify equipment rental configuration into the dedicated gear rental page, eliminating the redundant modal. Reorganize the boat manifest table to place Doc checks before Status. Establish strict separation of concerns: Status contains read-only indicators (Medical, Waiver, Gear, EAN32), while Doc checks contains interactive actions (Certification Card, Gas approval, and formal Physician Clearance). Enforce audited physician clearance for flagged divers and standardize terminology to Medical Clearance and Medical hold.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
- Resolves gas mix assignment overwrite in _apply_diver_paperwork_for_unit_item by removing redundant duplicate assignment. - Removes dead branch in update_participant; performs check_nitrox_eligibility when updating participant gas mix, assigning APPROVED if eligible and PENDING_APPROVAL if unverified instead of unconditionally bypassing checks. - Eliminates redundant queries in get_checkout_context by fetching DivingCenterBookingSettings once and reusing it for default_valve_fitting, daily_insurance_price, and rental_equipment_pricing. - Formats test files to resolve the Ruff Lint and Format GitHub Actions CI failure. - Updates make lint-backend and make lint-backend-fix via run-backend-lint.sh to dynamically target all modified Python files across both app and tests, matching GitHub Actions CI behavior.
…f format - Updates test_nitrox_requires_qualifying_certification in test_center_booking_ops_api.py to assert the new non-blocking walk-in behavior (201 Created with PENDING_APPROVAL) and tests the boarding gate blocking unverified EANx until approved. - Formats test_nitrox_service.py to resolve the GitHub Actions Ruff Lint and Format failure.
9d91642 to
44fdc89
Compare
Consolidate equipment terminology to Lead Weights across the booking wizard, gear profiles, and operations dashboard. Apply standard sizing defaults for full equipment rentals and remove redundant badge labels.
Update agency certification gas specifications so recreational depth ratings default to Air while specialized ratings grant Nitrox. Connect Nitrox eligibility to the diver's active portfolio in checkout context, and treat unverified EAN32 bookings as non-blocking pending dockside verification with support for secondary Nitrox credentials.
Add default cylinder valve fittings and daily insurance pricing to center booking settings in consolidated database migration 0107. Unify equipment rental configuration into the dedicated gear rental page, eliminating the redundant modal.
Reorganize the boat manifest table to place Doc checks before Status. Establish strict separation of concerns: Status contains read-only indicators (Medical, Waiver, Gear, EAN32), while Doc checks contains interactive actions (Certification Card, Gas approval, and formal Physician Clearance). Enforce audited physician clearance for flagged divers and standardize terminology to Medical Clearance and Medical hold.