Repository navigation
ci: run the tutorials on PyTorch 2.14 - #119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This switches the tutorials CI to PyTorch 2.14.0 (torchvision 0.29.0), matching kornia's PR CI.
Until now the jobs were labelled
torch-2.5.1but ran something else.kornia/workflows/.github/actions/env@v1.13.0installedtorch==2.5.1+cpuandtorchvision==0.20.1+cpu, and thenmake setup(torch>=2.8.0) replaced both withtorch 2.14.1+cu130/torchvision 0.29.1+cu130from PyPI. That means a full CUDA download on a CPU runner, and an unpinned torch. From the 2026-10-05 scheduled run:Changes:
testjob: inlined fromkornia/workflows/.github/workflows/tutorials.yml@v1.13.0, with the same steps. The reusable workflow hardcodesextra-deps: torchvision==0.20.1+cpu, which only installs alongside torch 2.5.1, so passingpytorch-version: 2.14.0to it would hit a resolver conflict. The job now passespytorch-versionand a matchingtorchvision==0.29.0+cputo the same env action.buildjob: the samepytorch-version/torchvisionpins for the env action.requirements.txt:torch>=2.14.0andtorchvision>=0.29.0. With the CPU wheels already installed,make setupkeeps them instead of pulling CUDA builds. kornia's own scheduledtutorialsjob (PIP_INDEX_URL=https://download.pytorch.org/whl/cpu) already resolves to2.14.1+cpu, so it still satisfies the new floor.The current daily failure,
fit_line.ipynbwith negative weights, is fixed separately in #118. This PR's owntestrun will hit that failure until #118 merges.What did you check?
Not verified: the workflow run itself. That will be this PR's CI.
Posted on behalf of @ducha-aiki by Claude (Opus 5.5).