Skip to content

Feature/double named dominance edges in index update - #347

Open
MartinKl wants to merge 10 commits into
mainfrom
feature/double-named-dominance-edges-in-index-update
Open

MartinKl wants to merge 10 commits into
mainfrom
feature/double-named-dominance-edges-in-index-update

Conversation

@MartinKl

@MartinKl MartinKl commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

This implements doubling named dominance edges into the default dominance component after performing a graph update. Doubling of edges takes place in AnnotationComponentType::apply_update_graph_index.

This might require benchmarking, I leave this to you @thomaskrause

…ce edges in the unnamed default dominance component. To keep this load off the corpus building side, it is integrated into apply_update_graph_index of AnnotationComponent
@MartinKl
MartinKl requested a review from thomaskrause October 9, 2026 09:17
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Commit a47fdd6

-------------
Diff Coverage
Diff: origin/main...HEAD, staged and unstaged changes
-------------
graphannis/src/annis/db/aql/model.rs (100%)
-------------
Total:   41 lines
Missing: 0 lines
Coverage: 100%
-------------

@thomaskrause
thomaskrause marked this pull request as draft October 12, 2026 16:45

@thomaskrause thomaskrause left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did change some things to make it more consistent with previous relANNIS behavior, e.g. the edges are only added if there is no other unnamed dominance component in another layer.

I also added a benchmark to check that that performance is not negativly impacted and overall this looks good to me. I will have to run the search tests/benchmarks with the newly imported corpora to check that the results are actually the same even after re-importing the corpora using the new code.

@thomaskrause
thomaskrause marked this pull request as ready for review October 12, 2026 17:26

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants