Skip to content

properly thread lambda through sie from - #661

Open
Yurlungur wants to merge 6 commits into
mainfrom
jmm/sie-from-rho-p
Open

Yurlungur wants to merge 6 commits into
mainfrom
jmm/sie-from-rho-p

Conversation

@Yurlungur

@Yurlungur Yurlungur commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

PR Summary

A user reported a bug where the code would segfault for InternalEnergyFromDensityPressure when called on EOS's that use lambdas. THis was because I missed threading that all the way through and tests on only ideal gas, didn't catch it. This implements a more thorough test suite and fixes the bug.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@Yurlungur Yurlungur self-assigned this Sep 25, 2026
@Yurlungur Yurlungur added the bug Something isn't working label Sep 25, 2026

@adamdempsey90 adamdempsey90 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that all the other EOs are good?

@Yurlungur

Copy link
Copy Markdown
Collaborator Author

For Spiner, the code should run even without the lambda. It's only stellarcollapse, Helmholtz, and zsplit, where it would have crashed. I'll add a test for Helmholtz.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants