Conversation
adamdempsey90
approved these changes
Sep 25, 2026
adamdempsey90
left a comment
Collaborator
There was a problem hiding this comment.
Did you check that all the other EOs are good?
Collaborator
Author
|
For Spiner, the code should run even without the lambda. It's only stellarcollapse, Helmholtz, and zsplit, where it would have crashed. I'll add a test for Helmholtz. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
A user reported a bug where the code would segfault for InternalEnergyFromDensityPressure when called on EOS's that use lambdas. THis was because I missed threading that all the way through and tests on only ideal gas, didn't catch it. This implements a more thorough test suite and fixes the bug.
PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: