Repository navigation
Conversation
Co-authored-by: rniebla <rniebla@launchdarkly.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Follow-up to #864, which updated
actions/setup-pythonfrom v3 to v7.Describe the solution you've provided
Since v4,
actions/setup-pythonwith no inputs does not install Python. Thus pre-commit uses the Python on the runner PATH (3.12), not the newest 3.x. Also, thepre-commit/actioncache key loses its Python version segment. This change addspython-version: '3.x'to the step in.github/workflows/go.ymlto keep the old behavior and cache key.Describe alternatives you've considered
Pin one exact Python version. This change does not do that, because v3 used the newest 3.x.
Additional context
This change touches only the
setup-pythonstep.