Repository navigation
Conversation
The ESLint configuration does not load this plugin, and no rule or eslint-disable comment uses it. Dependabot PR #869 tried to update it from 4.6.2 to 7.1.1. This change removes the package instead. npm 11.19.1 generated the lockfile change. CI uses this version through Node lts/*. Co-authored-by: rniebla <rniebla@launchdarkly.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Dependabot PR #869 tried to update
eslint-plugin-react-hooksfrom 4.6.2 to 7.1.1. That PR is closed.Describe the solution you've provided
This change removes
eslint-plugin-react-hooksfrominternal/dev_server/ui. ESLint does not load the plugin, so the package does nothing.These facts show that the plugin is not used:
eslint.config.jsdoes not import the plugin. It loads only@eslint/js,typescript-eslint, andeslint-plugin-react.react-hooks, other thanpackage.jsonandpackage-lock.json. Noeslint-disablecomment exists in the UI source.npm explainshows that only the rootpackage.jsonrequires the plugin.npm uninstall eslint-plugin-react-hooksmade the change. I used npm 11.19.1 because CI uses Nodelts/*, which is Node 24.22.0 with npm 11.19.1. The diff removes one line frompackage.jsonand one 13-line block frompackage-lock.json. npm 11.6.2 also changedpeerandlibcfields in other packages, so I did not use it.The resolved ESLint rules did not change. I ran
eslint --print-configfor each of the 25 files thatnpm run lintchecks, before and after the change. The two outputs are the same:react-hooks/rules@typescript-eslint,react@typescript-eslint,react75b7a32a…99ed075b7a32a…99ed0I ran the CI steps on Node 24.22.0 and npm 11.19.1.
npm ci,npm run lint,npm run prettier:write,npm test(5 of 5 tests pass), andnpm run buildall pass. After the build,git diff --exit-codefound no changes, so the committeddist/did not change.Describe alternatives you've considered
Dependabot PR #869 updated the plugin to 7.1.1. That update changes nothing, because ESLint does not load the plugin. Another option is to turn on the plugin in
eslint.config.js. That option adds new lint rules, so it needs a separate change.Additional context
Another open change also edits
package-lock.json. If that change merges first, this branch will be rebased onmainand the lockfile will be generated again.