Repository navigation
feat: [SEC-7263] Add dependency-scan GitHub Actions workflow - #12
kparkinson-ld wants to merge 2 commits into
Conversation
Co-Authored-By: Kane Parkinson <kparkinson@launchdarkly.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
pkaeding
left a comment
There was a problem hiding this comment.
For public repos, we can't use this resuable workflow. I will have to check my notes to find the way to do this...
|
Thanks for the feedback @pkaeding! I understand that the current reusable workflow approach isn't suitable for public repositories like support-knowledge. I'm ready to implement the correct approach for public repos once you find the appropriate method in your notes. Just let me know what changes are needed and I'll update the workflow accordingly. Should I hold off on any changes until you provide the correct approach for public repositories? |
|
Update: I've identified that this issue affects multiple public repositories in the task list: 📋 Public repositories requiring the corrected approach:
📋 Internal repositories (working correctly):
Once you provide the correct approach for public repos, I'll be ready to update all three public repositories with the appropriate dependency-scan workflow configuration. This will ensure consistent implementation across all repository types. |
@pkaeding That's because the source repo of the reusable workflow must be public as well right? We have this existing repo https://github.com/launchdarkly/gh-actions with other shared actions/workflows and it is public. Is there any reason not to migrate it there? We could duplicate it temporarily to avoid breaking things for existing configurations. |
feat: SEC-7263 Add dependency-scan GitHub Actions workflow
Summary
Adds a new GitHub Actions workflow for dependency scanning to the support-knowledge repository, following the model established in launchdarkly/ld-vsts#64. The workflow uses LaunchDarkly's centralized
common-workflowsdependency scanning functionality and is configured to run on pull requests and pushes to the main branch.Key configuration decision: Uses
types: 'generic'since this repository contains miscellaneous scripts and tools without a clear package manager (no package.json, go.mod, etc.).Review & Testing Checklist for Human
Notes
Related Jira issue: SEC-7263: Investigate impact of compromised NPM packages: debug and chalk