Repository navigation
Conversation
The CRS of the coordinates in a CQL2-JSON filter was set on the shared object mapper before the filter was read. With concurrent requests, a filter could be read with the CRS of another request, e.g. a stored query with coordinates in EPSG:25832 was read as CRS84. The coordinates were then rejected as invalid, which failed the request with an internal error, also after a response had already been started. The CRS is now bound to the thread that reads the filter.
…eature stream The collection metadata of a feature stream is published when the stream starts. When the first query fails (e.g. a filter that the database rejects), the stream ended with the error without ever starting, and a caller waiting for the metadata blocked forever; the error was never logged. The metadata is now completed with the stream error when the stream ends before it started.
cportele
force-pushed
the
api-validation-fixes-part1
branch
from
October 19, 2026 17:47
e3b38b3 to
a139b09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two major fixes found by testing several ldproxy APIs with schemathesis and under parallel load.
(
FeatureStreamImpl): the collection metadata of a feature stream is published when the streamstarts, which for SQL is the first row of the meta query. When the database rejected that query
(e.g. a filter value that PostgreSQL does not accept), the stream ended with the error without
ever starting, a caller waiting for the metadata blocked forever, and the error was never logged.
Each such request kept a request thread.
FeatureStreamImplnow completes the metadata with thestream error (or an
IllegalStateException, if there is none) when the stream ends before itstarted. Single features were not affected (their stream starts before the query is executed).
The read-stall timeout does not apply in this case, the read has already ended.
CqlImpl): the CRS of the coordinateswas set as injectable value on the shared object mapper before a filter was read. Under
concurrent requests a filter could be read with the CRS of another request, e.g. a stored query
with coordinates in EPSG:25832 was read as CRS84; the coordinates were then rejected, an internal
error, also after the response had been started (truncated JSON with status 200). The CRS is now
bound to the reading thread. (A per-call
ObjectReaderdoes not work: nested deserializers getthe shared mapper as codec.)