Repository navigation
fix parameters and numbers as arguments of CQL2 functions in stored queries - #662
Merged
Merged
Conversation
…ueries A stored query with a parameter as the argument of a function, e.g. a custom function S_DWITHIN(geometry, $point, $distance), failed with an SQL error, because the parameter was never replaced by its value: the copying visitor returned functions unchanged instead of rebuilding them from the visited arguments. All visitors derived from CqlVisitorCopy now also reach into the arguments of functions. Numeric and boolean literals as arguments of a function were written to CQL2 JSON as strings, so a filter that is written and read again, as stored and ad-hoc queries are, failed the type check of a function that expects a number. The literals are now written with their type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A stored query with a parameter as the argument of a function, e.g. a custom function S_DWITHIN(geometry, $point, $distance), failed with an SQL error, because the parameter was never replaced by its value: the copying visitor returned functions unchanged instead of rebuilding them from the visited arguments. All visitors derived from CqlVisitorCopy now also reach into the arguments of functions.
Numeric and boolean literals as arguments of a function were written to CQL2 JSON as strings, so a filter that is written and read again, as stored and ad-hoc queries are, failed the type check of a function that expects a number. The literals are now written with their type.