Repository navigation
Add a pull request template for plugin submissions - #5
Merged
Merged
Conversation
Submissions so far are a few short paragraphs on what the plugin does, reads, changes and sends, and that is what the maintainer reads first. The template now prompts for exactly that, in a comment that leaves only the repository and image lines behind. A checklist naming some of the terms read as if the rest did not count, so it points at SUBMITTING.md for all of them instead.
…checklist The previous commit cut the sections and the checklist down to a prompt. They are back as submitted, and the checklist now covers every term a submitter answers for, adding the ones it left out: no PHP, secrets and .env, the token, hooks, analytics and opt-in, page script reach, reused names, honest descriptions, the image count and the security response.
A plugin can take over a job from Lerd under provides, which belongs among what it adds, and an image pinned to a digest is accepted as well as a version tag, as SUBMITTING.md prefers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
.github/pull_request_template.md, so a pull request against this repository opens with the sections a submission needs instead of an empty box.It follows SUBMITTING.md and the example in #1:
requires, thelerdbound andplatforms.SUBMITTING.md now points at it under "How approval works", so a submitter knows to fill it in.
It is only a starting point: nothing in it is enforced, and the check still decides what blocks.
Tested on a fork: a new pull request there opens with the template filled in.