Repository navigation
fix(cli): prevent hangs when paste markers span input chunks - #387
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasting text could leave the prompt permanently waiting for the bracketed-paste end marker when that marker was split across terminal input events. Subsequent typing and Enter were then buffered instead of handled. A 1014-byte payload split at the 1024-byte boundary reproduces the failure.
Preserve partial start/end markers between input events and process each completed paste once. This also preserves input before a paste and consecutive pastes in one event. Standalone Esc remains responsive, and pending input is discarded when the handler is deactivated or unmounted.
Validation:
npm run test --workspace @vegamo/deepcode-cli.npm run checkpasses (type checking, lint, and formatting).Closes #377