Repository navigation
fix(ceremony): give a notarized request 30 seconds - #165
Merged
Merged
Conversation
The 10-second send-through-attestation budget fails GitHub's identity request on GitHub-hosted runners about half the time: measured from the notary's "starting Proxy-TLS" to "attestation ready", it took 5.0–10.6 s across eight runner runs (bimodal: about 5–6 s or 8–10.6 s), against 5.0–5.8 s on a developer laptop. The token and identity sessions prove at once on the same CPU, so a slower machine stretches both, and a user's device can be slower than a runner. 30 s is about three times the slowest runner measurement. X's 30-second code deadline, not this budget, now bounds X's token request; a token exchange that slow fails with X's own error. Assisted-by: Claude Opus 5.5 Signed-off-by: SupremaLex <georglutsenko@gmail.com>
Wondertan
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the ceremony's per-request notarization budget (
REQUEST_TIMEOUT_MSints/packages/ceremony/src/notary/session.ts) from 10 s to 30 s.Why
GitHub's identity request often takes longer than 10 s on a GitHub-hosted runner, and the ceremony then fails with "Notarization request timed out". The notary logs the cut-off as
verification failed during zk execution … unexpected end of fileat the moment the browser gives up.Measured from the notary's "starting Proxy-TLS" to "attestation ready", with the budget raised so nothing was cut off:
Runners are bimodal (about 5–6 s or 8–10.6 s), consistent with different CPU types; the token and identity sessions prove at the same time on the same CPU. GitHub's response (2,902 bytes) is about twice X's, so GitHub crosses the limit first. A user's device can be slower than a runner.
30 s is about three times the slowest runner measurement.
Trade-off
The setup budget comment said both budgets together kept X's token request inside X's 30-second authorization-code deadline. With 30 s that deadline, not this budget, bounds X's token request: an exchange that slow fails with X's own error instead of a timeout. X's requests measured 2.5–4 s on runners.
Checks
vitest run src/notary/: 148 passed. The timeout test advances to the new budget.pnpm typecheck,pnpm lint,pnpm fmt:check: pass.