Repository navigation
Conversation
Infer the return types of both UInt.view overloads to defer BigUIntView instantiation while Fp and UInt are being resolved. Preserve the view bodies, concrete return types, qualifiers, and function attributes. Add mutable and const view checks and a standalone factorial caller. Run the caller in the existing CI jobs so unrelated bignum instantiations cannot mask the regression. Fixes libmir#485. AI-Assisted-By: Codex (GPT-6 Astra Medium)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A standalone
factorial(3)call can fail with anFp!128forward-reference error, including when reached through mir-stat's integer-shape gamma PDF. Inferring the return types of bothUInt.viewoverloads defers theBigUIntViewinstantiation that exposes this cycle. The method bodies, concrete view types, qualifiers, and attributes remain unchanged.Add mutable/const view tests and a separate factorial regression executable. The standalone caller is important: prior bignum instantiations in the normal library test suite can mask the failure. Run it in the existing Windows, Linux, and macOS CI jobs.
Validation:
Fixes #485.
AI-Assisted-By: Codex (GPT-6 Astra Medium)