Repository navigation
Fix builder test in builds without chain-esplora - #1130
Open
benthecarman wants to merge 2 commits into
Open
benthecarman wants to merge 2 commits into
benthecarman wants to merge 2 commits into
Conversation
The `channel_manager_read_failure_fails_build` test never configured a chain source and relied on the builder's default Esplora fallback. Without the `chain-esplora` feature there is no fallback, so the build failed with `ChainSourceSetupFailed` before the channel manager read the test is meant to exercise. Configure an Esplora or Electrum chain source explicitly. Neither connects during `build`, so no server is needed. Skip the test if neither is enabled, as Bitcoind fetches the chain tip during `build` and fails before the channel manager read when no server is reachable. This change was written with the help of Claude Code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The PostgreSQL workflow only compiled the library tests for the `chain-electrum,storage-postgres` feature set. Building and running the library tests for that set catches failures that only show up without the default features, such as tests that rely on the default Esplora chain source. Set `TEST_POSTGRES_URL` on the step so that the PostgreSQL store tests use the workflow's PostgreSQL service, the same as the later steps. This change was written with the help of Claude Code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Oct 7, 2026
| #[cfg(any(feature = "chain-esplora", feature = "chain-electrum"))] | ||
| fn channel_manager_read_failure_fails_build() { | ||
| let builder = NodeBuilder::new(); | ||
| // Esplora and Electrum don't connect during `build`, so no server is needed. |
Collaborator
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
channel_manager_read_failure_fails_buildrelied on the default Esplora chain source, so it failed withChainSourceSetupFailedin builds withoutchain-esplora. Configure a chain source explicitly, and run the sparse PostgreSQL lib tests in CI instead of only compiling them.