Repository navigation
Expose PostgreSQL lease contention as a build error - #1133
Merged
tnull merged 1 commit intoOct 7, 2026
Merged
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
reviewed
Oct 7, 2026
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
| use crate::builder::{BuildError, NodeBuilder}; |
Collaborator
There was a problem hiding this comment.
It' s a bit odd to pull in Builder logic into the store. If we want to test that it should probably live somewhere in integration tests. Otherwise fine to just not add coverage of the BuildError here.
Return KVStoreAlreadyInUse when PostgreSQL lease acquisition reports an occupied store, allowing applications to retry node construction. Keep other setup errors as KVStoreSetupFailed and avoid logging expected contention as a setup failure. Document the new error on both builder interfaces and verify it in the PostgreSQL integration test. Keep lease collision and schema rollback coverage at the store level.
joostjager
force-pushed
the
postgres-lease-contention-error
branch
from
October 7, 2026 14:40
d7427c2 to
aa4e673
Compare
tnull
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return KVStoreAlreadyInUse when PostgreSQL lease acquisition reports an occupied store, allowing applications to retry node construction. Keep other setup errors as KVStoreSetupFailed and avoid logging expected contention as a setup failure.
Document the new error on both builder interfaces and exercise it through the existing lease collision and schema rollback test.