Repository navigation
Reject non-UTF-8 MCP credential env vars - #304
Open
benthecarman wants to merge 1 commit into
Open
benthecarman wants to merge 1 commit into
benthecarman wants to merge 1 commit into
Conversation
A set but non-UTF-8 LDK_MACAROON was treated as unset, so the bridge silently loaded the admin macaroon from disk instead. LDK_BASE_URL and LDK_TLS_CERT_PATH fell back to the config in the same way. Return an error that names the variable so a malformed override fails rather than selecting a different credential or endpoint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I've assigned @tankyleo as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LDK_MACAROON,LDK_BASE_URL, andLDK_TLS_CERT_PATHwere read withstd::env::var(..).ok(). A value that was set but not valid UTF-8 wastreated as unset. A malformed
LDK_MACAROONtherefore silently fellback to the on-disk admin macaroon. These now return an error naming
the variable.
Found by Project Loupe.