Repository navigation
Fix log cleanup for bare relative log paths - #306
Open
benthecarman wants to merge 1 commit into
Open
benthecarman wants to merge 1 commit into
benthecarman wants to merge 1 commit into
Conversation
When the log file is configured as a bare file name such as `ldk-server.log`, its parent is an empty path. Passing that to `read_dir` fails, so rotated archives were never removed and `log_max_files` had no effect. Treat an empty parent as the current working directory, which is where the log file itself is opened. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I've assigned @valentinewallace as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the log file is set to a bare file name such as
ldk-server.log,Path::parent()returns an empty path.cleanup_old_logspassed that tofs::read_dir, which fails, so rotated archives were never deleted andlog_max_fileshad no effect.An empty parent now means the current working directory. That is the directory the log file itself is opened in.
Found by Project Loupe