Repository navigation
Support for rdma settings on lke nodepools - #1063
Open
awalker125-akamai wants to merge 5 commits into
Open
awalker125-akamai wants to merge 5 commits into
awalker125-akamai wants to merge 5 commits into
Conversation
awalker125-akamai
requested review from
lgarber-akamai and
mawilk90
and
a balanced review from Copilot
and removed request for
a team
October 26, 2026 13:53
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The additive changes have no identified blocking issues; outgoing request-serialization coverage remains a non-blocking improvement.
1 open issue
What changed in this PR
Adds creation-time networking support to LKE Enterprise node pools, allowing callers to configure ordered VPC and RDMA interfaces through the Go client.
Changes:
- Adds interface types and networking models to node pool responses and create options.
- Preserves networking in
GetCreateOptions()while leaving update options unchanged. - Adds create/get response tests and JSON fixtures.
| File | Description |
|---|---|
test/unit/lke_node_pools_test.go |
Adds RDMA node pool create/get tests. |
test/unit/fixtures/lke_node_pool_rdma_get.json |
Supplies a GET response with ordered interfaces. |
test/unit/fixtures/lke_node_pool_rdma_create.json |
Supplies a create response with ordered interfaces. |
lke_node_pools.go |
Adds networking models, fields, and create-option copying. |
Review effort: Balanced
| // Networking configures the ordered set of VPC-backed interfaces for LKE Enterprise node pools. | ||
| // Accepted only at creation time; immutable after the pool is created. | ||
| // NOTE: Networking may not currently be available to all users and can only be used with v4beta. | ||
| Networking *LKENodePoolNetworking `json:"networking,omitzero"` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📝 Description
What does this PR do and why is this change necessary?
Adds networking field support to LKE node pools, enabling callers to configure the ordered set of VPC-backed interfaces (including RDMA interfaces) attached to nodes in an LKE Enterprise pool.
New types:
Changed structs:
Notes:
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
go test ./test/unit/... -run "TestLKENodePoolRDMA"
Two new unit tests cover create and get: