Repository navigation
Conversation
mawilk90
requested review from
ezilber-akamai and
psnoch-akamai
and
a balanced review from Copilot
and removed request for
a team
October 27, 2026 11:01
mawilk90
added
improvement
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Randomizing the shared package-level label breaks existing fixture-playback assertions in unrelated integration tests.
1 open issue
What changed in this PR
This PR addresses flaky NodeBalancer and IP-address tests in the Go client's integration suite without changing the public client API.
Changes:
- Randomizes NodeBalancer labels and checks their stable prefix.
- Allows hourly-only NodeBalancer pricing and temporarily disables an IP-tag assertion for ARB-8378.
- Refreshes NodeBalancer fixtures and sanitizes addresses in the Valkey fixture.
| File | Description |
|---|---|
test/integration/nodebalancers_test.go |
Randomizes labels and adjusts label assertions. |
test/integration/nodebalancer_types_test.go |
Accepts either positive hourly or monthly pricing. |
test/integration/network_ips_test.go |
Temporarily disables the non-reserved IP tags assertion. |
test/integration/fixtures/TestNodeBalancerType_List.yaml |
Updates available types and nullable monthly prices. |
test/integration/fixtures/TestNodeBalancer_With_ReservedIP_Create.yaml |
Refreshes reserved-IP creation responses. |
test/integration/fixtures/TestNodeBalancer_Create.yaml |
Refreshes regions and NodeBalancer creation responses. |
test/integration/fixtures/TestNodeBalancer_Create_Type.yaml |
Refreshes explicit-type creation responses. |
test/integration/fixtures/TestNodeBalancer_Create_BackendConnectivity_Common.yaml |
Refreshes IPv6 backend-connectivity responses. |
test/integration/fixtures/TestDatabase_Valkey_Suite.yaml |
Sanitizes recorded resolver addresses. |
Review effort: Balanced
zliang-akamai
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixes related to failing IP address and nodebalancer smoke & integration tests
✔️ How to Test
make fixtures TEST_ARGS="-run TestIPAddresses_List_smoke"make fixtures TEST_ARGS="-run TestNodeBalancer"make fixtures TEST_ARGS="-run TestIAM_GetIOReadyForNotAttachedVolume"make fixtures TEST_ARGS="-run TestObjectStorageKey_GetFound"make fixtures TEST_ARGS="-run TestSSHKey_GetFound"make test-int