Repository navigation
chore: replace Qt keywords with macros (QT_NO_KEYWORDS) - #1788
18202781743 wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThe PR enables QT_NO_KEYWORDS and systematically migrates Qt keyword syntax to Q_EMIT/Q_SIGNALS/Q_SLOTS, while normalizing SPDX years; however, the diff also deletes notifyaccessor.cpp and contains extensive accidental line-collapsing changes that should be carefully reviewed or reverted before merging. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
8a3bf79 to
e1486c9
Compare
|
Sorry @18202781743, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 2 days and 21 hours by commenting |
d2b6606 to
ad2cd0f
Compare
Replace emit/signals:/slots: with Q_EMIT/Q_SIGNALS:/Q_SLOTS: to avoid naming conflicts with pure C++ or third-party libraries. Add QT_NO_KEYWORDS compile definition after project() in CMakeLists.txt. 将 emit/signals:/slots: 替换为 Q_EMIT/Q_SIGNALS:/Q_SLOTS:, 避免纯 C++ 或第三方库引入时的命名冲突。在 CMakeLists.txt 中 添加 QT_NO_KEYWORDS 编译定义。 Log: 替换Qt关键字为宏形式并添加QT_NO_KEYWORDS编译定义 Influence: 无行为变更,仅关键字到宏的替换,解决第三方库命名冲突。
ad2cd0f to
eb109c5
Compare
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本报告由 AI 代码审查工具自动生成 |
Replace emit/signals:/slots: with Q_EMIT/Q_SIGNALS:/Q_SLOTS: to avoid naming conflicts with pure C++ or third-party libraries.
Also adds QT_NO_KEYWORDS compile definition in CMakeLists.txt and fixes SPDX copyright year ranges.
Related issue: DDE-499
Summary by Sourcery
Adopt Qt keyword macros across the project and disable legacy Qt keywords to improve compatibility with standard C++ and third-party libraries.
Enhancements:
Build:
Tests:
Chores: