Skip to content

chore: replace Qt keywords with macros (QT_NO_KEYWORDS) - #1788

Open
18202781743 wants to merge 1 commit into
masterfrom
agent/developer/dea1631977fa
Open

18202781743 wants to merge 1 commit into
masterfrom
agent/developer/dea1631977fa

Conversation

@18202781743

@18202781743 18202781743 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Replace emit/signals:/slots: with Q_EMIT/Q_SIGNALS:/Q_SLOTS: to avoid naming conflicts with pure C++ or third-party libraries.

Also adds QT_NO_KEYWORDS compile definition in CMakeLists.txt and fixes SPDX copyright year ranges.

Related issue: DDE-499

Summary by Sourcery

Adopt Qt keyword macros across the project and disable legacy Qt keywords to improve compatibility with standard C++ and third-party libraries.

Enhancements:

  • Replace Qt signal and slot keywords with portable Q_EMIT, Q_SIGNALS, and Q_SLOTS macros throughout the codebase.
  • Enable QT_NO_KEYWORDS globally in the CMake build to prevent Qt keyword naming conflicts.

Build:

  • Add the QT_NO_KEYWORDS compile definition to the project build configuration.

Tests:

  • Update affected tests to use the Qt keyword macros consistently.

Chores:

  • Update SPDX copyright year ranges in the affected source files.

@deepin-ci-robot

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Reviewer's Guide

The PR enables QT_NO_KEYWORDS and systematically migrates Qt keyword syntax to Q_EMIT/Q_SIGNALS/Q_SLOTS, while normalizing SPDX years; however, the diff also deletes notifyaccessor.cpp and contains extensive accidental line-collapsing changes that should be carefully reviewed or reverted before merging.

File-Level Changes

Change Details Files
Enabled Qt keyword suppression and migrated Qt signal/slot declarations and emissions to macro forms across the project.
  • Added the global QT_NO_KEYWORDS compile definition.
  • Replaced emit, signals, and slots usages with Q_EMIT, Q_SIGNALS, and Q_SLOTS in production, example, generated, and test code.
  • Updated SPDX copyright year ranges to normalized hyphenated ranges.
CMakeLists.txt
applets/**/*.h
applets/**/*.cpp
example/**/*.h
example/**/*.cpp
frame/**/*.h
frame/**/*.cpp
panels/**/*.h
panels/**/*.cpp
tests/**/*.cpp
tests/**/*.h
toolGenerate/**/*.h
Removed the notification accessor implementation and introduced broad unintended source formatting/content changes in otherwise unrelated code.
  • Deleted panels/notification/center/notifyaccessor.cpp.
  • Collapsed many line breaks and statement boundaries across application, panel, model, notification, test, and generated files.
  • Changed generated DBus header string literals and declarations as part of the line-collapsing edits.
panels/notification/center/notifyaccessor.cpp
applets/dde-apps/appgroupmanager.cpp
applets/dde-apps/appitemmodel.h
example/layershell-example/main.cpp
frame/models/kextracolumnsproxymodel.cpp
panels/dock/constants.h
panels/dock/pluginmanagerextension.cpp
panels/dock/taskmanager/*.cpp
panels/notification/**/*.cpp
tests/**/*.cpp
toolGenerate/qdbusxml2cpp/*.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@18202781743
18202781743 force-pushed the agent/developer/dea1631977fa branch 2 times, most recently from 8a3bf79 to e1486c9 Compare November 2, 2026 05:40
@18202781743
18202781743 marked this pull request as ready for review November 2, 2026 05:41
@sourcery-ai

sourcery-ai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Sorry @18202781743, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 2 days and 21 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@18202781743
18202781743 force-pushed the agent/developer/dea1631977fa branch 3 times, most recently from d2b6606 to ad2cd0f Compare November 2, 2026 09:41
Replace emit/signals:/slots: with Q_EMIT/Q_SIGNALS:/Q_SLOTS: to avoid
naming conflicts with pure C++ or third-party libraries. Add QT_NO_KEYWORDS
compile definition after project() in CMakeLists.txt.

将 emit/signals:/slots: 替换为 Q_EMIT/Q_SIGNALS:/Q_SLOTS:,
避免纯 C++ 或第三方库引入时的命名冲突。在 CMakeLists.txt 中
添加 QT_NO_KEYWORDS 编译定义。

Log: 替换Qt关键字为宏形式并添加QT_NO_KEYWORDS编译定义
Influence: 无行为变更,仅关键字到宏的替换,解决第三方库命名冲突。
@18202781743
18202781743 force-pushed the agent/developer/dea1631977fa branch from ad2cd0f to eb109c5 Compare November 2, 2026 10:44
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交将 Qt 关键字(signals/slots/emit)统一替换为宏形式(Q_SIGNALS/Q_SLOTS/Q_EMIT), 并在 CMakeLists.txt 中添加 QT_NO_KEYWORDS 编译定义,避免第三方库关键字冲突。 变更范围清晰、替换一致完整,四维度均无问题,无安全漏洞。

🔍 详细分析

1. 语法逻辑 ✅

评价: 语法正确,逻辑清晰 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 代码结构清晰,注释完整 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


3. 代码性能 ✅

评价: 性能良好,资源使用合理 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 存在0个安全漏洞 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例


本报告由 AI 代码审查工具自动生成

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants