Skip to content

fix: use theme-aware color for magnifier background #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GongHeng2017 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Draft

fix: use theme-aware color for magnifier background #436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions reader/browser/BrowserMagniFier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Copyright (C) 2019 ~ 2020 Uniontech Software Technology Co.,Ltd.
// SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2023-2026 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: GPL-3.0-or-later

Expand All @@ -13,9 +13,11 @@
#include <QDebug>
#include <QIcon>
#include <QMutexLocker>
#include <QMetaObject>

Check warning on line 16 in reader/browser/BrowserMagniFier.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QMetaObject> not found. Please note: Cppcheck does not need standard library headers to get proper results.
#include <QPainterPath>

Check warning on line 17 in reader/browser/BrowserMagniFier.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <QPainterPath> not found. Please note: Cppcheck does not need standard library headers to get proper results.

#include <DGuiApplicationHelper>

Check warning on line 19 in reader/browser/BrowserMagniFier.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

Include file: <DGuiApplicationHelper> not found. Please note: Cppcheck does not need standard library headers to get proper results.

ReadMagnifierManager::ReadMagnifierManager(QWidget *parent) : QThread(parent)
{
// qCDebug(appLog) << "ReadMagnifierManager created";
Expand Down Expand Up @@ -204,7 +206,7 @@
painter.drawImage(0, 0, im.scaled(static_cast<int>(240 * dApp->devicePixelRatio()), static_cast<int>(240 * dApp->devicePixelRatio()), Qt::KeepAspectRatio, Qt::SmoothTransformation));
} else {
// qCDebug(appLog) << "BrowserMagniFier::setMagniFierImage() - Drawing white background for null image";
painter.fillRect(this->rect(), Qt::white);
painter.fillRect(this->rect(), DGuiApplicationHelper::instance()->applicationPalette().itemBackground().color());
}
painter.restore();

Expand Down
Loading