Skip to content

add Dora Burbanks parameters - #434

Open
dora-burbank wants to merge 3 commits into
lmu-osc:mainfrom
dora-burbank:main
Open

dora-burbank wants to merge 3 commits into
lmu-osc:mainfrom
dora-burbank:main

Conversation

@dora-burbank

Copy link
Copy Markdown

No description provided.

@MalikaIhle

Copy link
Copy Markdown
Member

Hi! The file appear empty of your parameters. Make sure your local file is saved, commit, push, and refresh your browser page where the pull request is - then open the tab 'file changed' and you should see your file with your parameters. Then I'll merge it !

@dora-burbank

Copy link
Copy Markdown
Author

Hi! The file appear empty of your parameters. Make sure your local file is saved, commit, push, and refresh your browser page where the pull request is - then open the tab 'file changed' and you should see your file with your parameters. Then I'll merge it !

I think I accidentally added my parameters to the original file and requested the pull. Apologies!

@MalikaIhle

Copy link
Copy Markdown
Member

indeed there is now two files committed: the template file and your copy. I only want your copy so your template file doesn't overwrite mine. can yyou return the template file to it's original state by deleting your changes?

Also in your copy, the color parameter needs only one color, not three.

@dora-burbank

Copy link
Copy Markdown
Author

indeed there is now two files committed: the template file and your copy. I only want your copy so your template file doesn't overwrite mine. can yyou return the template file to it's original state by deleting your changes?

Also in your copy, the color parameter needs only one color, not three.

I think that's done now.

@MalikaIhle

Copy link
Copy Markdown
Member

mmh no there is no new commit to this pull request.
Make sure your local file is saved, commit, push, and refresh your browser page where the pull request is - then open the tab 'file changed' and you should see only your file with your parameters.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants