Repository navigation
Add a subtle Gotcha to Front Brightness and Rear Brightness help - #109
Conversation
|
For ease of reading (as compared to settings.xml), below is the modified text: On very low brightness levels the LEDs will lose color precision and eventually turn off completely. This is a limitation of the LED strips and can’t be alleviated. |
|
You're adding the note to front and rear brightness but not to headlights and taillights brightness. I certainly don't like the same thing being repeated 4 times, but it's not too consistent and also feels like the added note on brightness related flashing should go into the headlights options first and foremost? |
|
The issue can happen in each case, Front, Rear, Headlights, Taillights.
But it's not going to happen in the typical Headlights/Taillights use case
of solid white up front and solid red rear as bright as possible. If one
were to go with an animation, then yeah, it applies. If someone goes with
a blue-ish Taillighy, it applies. So I left Headlights and Taillights out
because that's getting too complicated.
…On Sun, Oct 18, 2026, 11:20 Lukáš Hrázký ***@***.***> wrote:
*lukash* left a comment (lukash/refloat#109)
<#109 (comment)>
You're adding the note to front and rear brightness but not to headlights
and taillights brightness. I certainly don't like the same thing being
repeated 4 times, but it's not too consistent and also feels like the added
note on brightness related flashing should go into the headlights options
first and foremost?
—
Reply to this email directly, view it on GitHub
<#109?email_source=notifications&email_token=BXIEQCSWCZJOQJSHLA6R6ZL5UTNTZA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMRVGE2TSOJZGM2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6251599934>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXIEQCVNDYM44PZLH2ZZ74D5UTNTZAVCNFSNUABFKJSXA33TNF2G64TZHM4DAOBXG43DONRQHNEXG43VMU5TKNRWHE3DMNZUGQ32C5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I'm not sure, that logic for only having it in front/rear is not clear and just addressing some very specific cases. Unless we come up with some clearer justification I'd lean towards copy-pasting into all 4 help texts, at least that's consistent. |
|
Makes sense. I'm tied up for the next 2.5 to 3 hours but can do after then
if that works.
…On Sun, Oct 18, 2026, 12:47 Lukáš Hrázký ***@***.***> wrote:
*lukash* left a comment (lukash/refloat#109)
<#109 (comment)>
I'm not sure, that logic for only having it in front/rear is not clear and
just addressing some very specific cases. Unless we come up with some
clearer justification I'd lean towards copy-pasting into all 4 help texts,
at least that's consistent.
—
Reply to this email directly, view it on GitHub
<#109?email_source=notifications&email_token=BXIEQCV5VXHUEULSS3VF7YT5UTXYRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMRVGI2DQMZTGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6252483305>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BXIEQCVBMQU2EHHKMCYPWUD5UTXYRAVCNFSNUABFKJSXA33TNF2G64TZHM4DAOBXG43DONRQHNEXG43VMU5TKNRWHE3DMNZUGQ32C5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Alright, "copy and paste" done, if you're still awake! |
dac4620 to
7d52ee6
Compare
|
I squashed the commits, did one very minor tweak and pushed to your branch. Merging, thanks. |
This edit describes an interesting condition found occasionally on some hardware and provides a simple remedy.