Repository navigation
Conversation
|
The number of changed files and lines in the PR hits at you probably not really knowing what you're going... |
|
Probably not, have no idea why it is showing all those files changes |
206dd74 to
d4dde28
Compare
|
the EOL characters messed things up, i have tried to fix and replace the branch, 7 files changed. If you think it is worth while, it woud be great to have it in there, reason is I am trying to use the FLOATY app, and I think it only follows official releases, else I would just keep it to myself. Either way |
|
Is it AI-generated? Do you actually understand the code? |
|
just forget it, hope to meet you in person one day |
|
I'm sorry, but I hope you understand by sending a vibed PR, you sign me up to do all the work to validate and polish the code for production. I can vibe stuff too, it's the non-AI work that still requires non-trivial resources. I think there's some ethic coming about with regards to AI, in particular if you're not an experienced developer in the given field. From my PoV you should upfront state the extent of AI usage, your own level of understanding of what you're submitting and all the things you've done to ensure you're submitting correct and good quality code... The default from the old days is the author has written every line of code and even if they've done a poor job, at least they invested the effort and the quality is usually apparent. That no longer applies and AI can still make mistakes. |
|
I thought it was a really trivial mod, except perhaps the makefile mod, but the rest is child's play, and very short mods, just added commentary and some logic to the status bar, that's it, but if it is too much work let it be. |
I have added two parameters that can help mimick the FM status bar behavior above a threshold speed.
Above this value the status bar fades off, unless motor duty cycle takes over following its warning logic. THe two parameters are boolean (whether or not to have this feature activated) and the speed threshold value for fade off.