Repository navigation
Enable pixman and use static linkage - #1700
Merged
Merged
Conversation
Upstream Vim has added a dependency on pixman in order for image feature to work. This was previously introducing an external linkage which does not work in MacVim (since we ship this as a standalone app) and so we turned it off in a previous commit. Here, we turn it back on, and change configuration to use static linking instead (similar to other dependencies like gettext). Just like the other dependencies, add a cached custom build version of this instead of the Homebrew one in order to build universal binaries and to support the deployment target we need. This change is necessary to get popup image to work in Vim with the latest upstream commit. Currently this feature only works in terminal Vim. GUI support will come later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream Vim has added a dependency on pixman in order for image feature to work. This was previously introducing an external linkage which does not work in MacVim (since we ship this as a standalone app) and so we turned it off in a previous commit. Here, we turn it back on, and change configuration to use static linking instead (similar to other dependencies like gettext).
Just like the other dependencies, add a cached custom build version of this instead of the Homebrew one in order to build universal binaries and to support the deployment target we need.
This change is necessary to get popup image to work in Vim with the latest upstream commit. Currently this feature only works in terminal Vim. GUI support will come later.